feat(vwc-accordion): viv-388 accordion #683
Conversation
|
🚀 Latest successful build of the PR deployed here. 🚀 |
| return opened; | ||
| } | ||
|
|
||
| openAll(): void { |
There was a problem hiding this comment.
is there a case where openAll is needed?
There was a problem hiding this comment.
I can only think this may be useful if it's a requirement to open all panels in desktop view but not on mobile.
I've messaged Joella to discuss if it's necessary
There was a problem hiding this comment.
just thinking it might be a property rather then a method. since a method will need to be called and if transitioned, can cause layout shift upon page render
| import { LitElement, property } from 'lit-element'; | ||
| import { VWCExpansionPanelBase } from './vwc-expansion-panel-base.js'; | ||
|
|
||
| export abstract class VWCExpansionPanelListBase extends LitElement { | ||
| @property({ type: Boolean, reflect: true }) | ||
| multi = false; | ||
|
|
||
| private expansionPanels: HTMLCollectionOf<VWCExpansionPanelBase> | undefined = undefined; | ||
|
|
||
| constructor() { | ||
| super(); | ||
| this.addEventListener('opened', this.handleOpened); | ||
| } |
There was a problem hiding this comment.
using base file for component is probably not a standard we want to carry out from MWC, if it's not being used by other components and is not a common class. I know it's the same with badge, but following the badge case we decided it
There was a problem hiding this comment.
Is there any possibility this base class will be useful for navigation? e.g. collapsing list-expansion-panel when another is opened
|
@JoelGraham93 is this still a draft? |
|
Resolved conflicts with latest expansion-panel updates.
|
Interesting point. @jshenkman does this sound like a potential requirement to remove |
|
|
SonarCloud Quality Gate failed.
|
Currently doesn't support nested expansion panels which will be required for navigation