[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply [EnforceRange] to the BluetoothUUID operations #133

Open
jyasskin opened this issue Jun 21, 2015 · 2 comments
Open

Apply [EnforceRange] to the BluetoothUUID operations #133

jyasskin opened this issue Jun 21, 2015 · 2 comments
Assignees
@jyasskin
Milestone
Initial GATT Comm...

Comments

@jyasskin
Copy link
Member

This would throw a TypeError for numeric values that aren't 32-bit UUID aliases.

This depends on https://www.w3.org/Bugs/Public/show_bug.cgi?id=28834, but we could willfully violate WebIDL and just make the UAs implement it.
@jyasskin jyasskin self-assigned this Jun 30, 2015
@jyasskin
Copy link
Member Author

We should apply it to canonicalUUID first, since strings and objects convert to 0 there, but stay as non-UUID strings for the other functions.

@jyasskin
Copy link
Member Author
jyasskin commented Jul 1, 2015

Also see https://www.w3.org/Bugs/Public/show_bug.cgi?id=28875

jyasskin added a commit to jyasskin/web-bluetooth-1 that referenced this issue Jul 1, 2015
@jyasskin
Enforce that canonicalUUID() is called with an in-range alias.
eb34786 
Issue WebBluetoothCG#133 tracks applying this to the other functions taking unsigned long.
This also allows some non-integer arguments, due to WebIDL details.
@jyasskin jyasskin mentioned this issue Jul 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyasskin jyasskin

Labels
None yet
Projects
None yet
Milestone
Initial GATT Communication
Development

No branches or pull requests
1 participant
@jyasskin