UGC-5176 Purge comments on QuickTools action #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8ece75
to
e694963
Compare
kasperekt
approved these changes
Feb 16, 2024
maaartyyynaa
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Description
In https://github.com/Wikia/unified-platform/pull/16602 A hook interface was added that allows plugging in additional logic that will be performed on a QuickTools revert / delete action.
To mass delete comments we introduced a job that does it asynchronously, as their volume can be potentially quite large, and with every comment deletion (purge) some extra logic has to be performed, potentially involving a couple DB calls.
To let the hook caller know whether any action was performed, before a job is executed, a quick lookup is performed to predetermine whether there's anything to remove.