[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent clients from accessing LAN subnets #49

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Prevent clients from accessing LAN subnets #49

merged 3 commits into from
Dec 3, 2019

Conversation

soffokl
Copy link
Member
@soffokl soffokl commented Nov 22, 2019 •
edited
Loading

Another part of this feature is here: mysteriumnetwork/node#1420

This PR enables internal OpenVPN packet filtering, which is platform-independent.

@soffokl soffokl added the enhancement New feature or request label Nov 22, 2019
@soffokl soffokl requested a review from zolia November 22, 2019 04:05
@soffokl soffokl self-assigned this Nov 22, 2019
@soffokl soffokl requested a review from a team November 22, 2019 04:05
@soffokl soffokl mentioned this pull request Nov 22, 2019
Merged
zolia
zolia reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor
@zolia zolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad thing here is that we cannot filter by port. In case we need to whitelist just one service (ie DNS) on LAN.

@soffokl soffokl requested a review from zolia November 25, 2019 05:12
@soffokl soffokl requested a review from Waldz November 28, 2019 05:24
@soffokl soffokl merged commit f04a257 into master Dec 3, 2019
@soffokl soffokl deleted the feature/filter-lan-subnets branch December 3, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iberflow iberflow iberflow approved these changes

@Waldz Waldz Waldz approved these changes

@zolia zolia Awaiting requested review from zolia

Assignees

@soffokl soffokl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soffokl @iberflow @Waldz @zolia