[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amf): Wrong enum causes for Radio Network Layer causes in N11 #15397

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(amf): Wrong enum causes for Radio Network Layer causes in N11 #15397

merged 1 commit into from
Apr 4, 2024

Conversation

brunohcfaria
Copy link
Collaborator

Summary

Fixes the enumerator related to N11 Radio Network Layer cause codes, outlined in #15396

Test Plan

Check the new cause code interpreted by the AMF when handling NG AP ErrorInidicationMessage.

@brunohcfaria
fix(amf): Wrong enum causes for Radio Network Layer causes for N11 pr…
08f3275 
…otocol

Fixes the enumerator related to N11 Radio Network Layer cause codes.

Signed-off-by: Bruno Faria <bruno.faria@ektrum.com>
@brunohcfaria brunohcfaria requested a review from a team as a code owner March 26, 2024 15:01
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 26, 2024
panyogesh
panyogesh approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor
@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

FeG Lint & Test

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 08f3275.

@github-actions GitHub Actions
Copy link
Contributor

DP Lint & Test

14 tests   14 ✔️  2m 19s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 08f3275.

@panyogesh panyogesh merged commit 5d58c69 into magma:master Apr 4, 2024
118 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyogesh panyogesh panyogesh approved these changes

@jordanvrtanoski jordanvrtanoski Awaiting requested review from jordanvrtanoski jordanvrtanoski is a code owner automatically assigned from magma/approvers-gw

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunohcfaria @panyogesh