Add quotes around each host in inventory #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi :-) Not sure what breaks the host list, though: What OS did you test it on and also with which Ansible version? |
|
I am developing on macOS and use one of the latest versions of Ansible. Not at home currently, but can check later. |
|
@maschmann I updated the PR to facilitate hosts with spaces in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "fixes" how the inventory is parsed.
Before it has surrounded the comma delimited hosts with double quotes.
For me this ended up in something like:
But Ansible can't connect to the host by having it formatted like this.
Adding quotes arounf each host resolves the issue for me:
This could be an issue for host names with spaces in it, or what do you think?I changed it to wrap each host with quotes. I think this should solve both cases :)