Enable bugprone-unchecked-optional-access, disable in files with warn…

…ings (flutter#42359) First part of flutter/flutter#127701
matanlurey · May 26, 2023 · 5293864 · 5293864
1 parent 24889bc
commit 5293864
Show file tree

Hide file tree

Showing 37 changed files with 177 additions and 0 deletions.
diff --git a/.ci.yaml b/.ci.yaml
@@ -278,6 +278,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"
@@ -298,6 +299,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"
@@ -541,6 +543,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"
@@ -563,6 +566,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"

diff --git a/.clang-tidy b/.clang-tidy
@@ -2,6 +2,7 @@
 # Note: Some of the checks here are used as errors selectively, see
 # //ci/lint.sh
 Checks: "bugprone-use-after-move,\
+bugprone-unchecked-optional-access,\
 clang-analyzer-*,\
 clang-diagnostic-*,\
 darwin-*,\

diff --git a/flow/layers/clip_path_layer_unittests.cc b/flow/layers/clip_path_layer_unittests.cc
@@ -14,6 +14,9 @@
 #include "flutter/fml/macros.h"
 #include "gtest/gtest.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -569,3 +572,5 @@ TEST_F(ClipPathLayerTest, EmptyClipDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/clip_rect_layer_unittests.cc b/flow/layers/clip_rect_layer_unittests.cc
@@ -12,6 +12,9 @@
 #include "flutter/flow/testing/mock_layer.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -545,3 +548,5 @@ TEST_F(ClipRectLayerTest, EmptyClipDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/clip_rrect_layer_unittests.cc b/flow/layers/clip_rrect_layer_unittests.cc
@@ -12,6 +12,9 @@
 #include "flutter/flow/testing/mock_layer.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -594,3 +597,5 @@ TEST_F(ClipRRectLayerTest, EmptyClipDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/color_filter_layer_unittests.cc b/flow/layers/color_filter_layer_unittests.cc
@@ -17,6 +17,9 @@
 #include "flutter/flow/testing/mock_layer.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -454,3 +457,5 @@ TEST_F(ColorFilterLayerTest, OpacityInheritance) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/container_layer_unittests.cc b/flow/layers/container_layer_unittests.cc
@@ -13,6 +13,9 @@
 #include "gtest/gtest.h"
 #include "include/core/SkMatrix.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -762,3 +765,5 @@ TEST_F(ContainerLayerDiffTest, ReplaceLayer) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/display_list_layer_unittests.cc b/flow/layers/display_list_layer_unittests.cc
@@ -11,6 +11,9 @@
 #include "flutter/flow/testing/diff_context_test.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -570,3 +573,5 @@ TEST_F(DisplayListLayerTest, OverflowCachedDisplayListOpacityInheritance) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/display_list_raster_cache_item.cc b/flow/layers/display_list_raster_cache_item.cc
@@ -16,6 +16,9 @@
 #include "flutter/flow/raster_cache_util.h"
 #include "third_party/skia/include/gpu/GrDirectContext.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 
 static bool IsDisplayListWorthRasterizing(
@@ -170,3 +173,5 @@ bool DisplayListRasterCacheItem::TryToPrepareRasterCache(
       });
 }
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/image_filter_layer_unittests.cc b/flow/layers/image_filter_layer_unittests.cc
@@ -15,6 +15,9 @@
 #include "include/core/SkPath.h"
 #include "third_party/skia/include/effects/SkImageFilters.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -710,3 +713,5 @@ TEST_F(ImageFilterLayerDiffTest, ImageFilterLayerInflatestChildSize) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/layer_raster_cache_item.cc b/flow/layers/layer_raster_cache_item.cc
@@ -7,6 +7,9 @@
 #include "flutter/flow/raster_cache_item.h"
 #include "flutter/flow/raster_cache_util.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 
 LayerRasterCacheItem::LayerRasterCacheItem(Layer* layer,
@@ -190,3 +193,5 @@ bool LayerRasterCacheItem::Draw(const PaintContext& context,
 }
 
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/opacity_layer_unittests.cc b/flow/layers/opacity_layer_unittests.cc
@@ -18,6 +18,9 @@
 #include "flutter/testing/display_list_testing.h"
 #include "gtest/gtest.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -742,3 +745,5 @@ TEST_F(OpacityLayerTest, FullyTransparentDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/layers/shader_mask_layer_unittests.cc b/flow/layers/shader_mask_layer_unittests.cc
@@ -13,6 +13,9 @@
 #include "flutter/fml/macros.h"
 #include "gtest/gtest.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -463,3 +466,5 @@ TEST_F(ShaderMaskLayerTest, SimpleFilterWithRasterCacheLayerNotCached) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/flow/raster_cache_unittests.cc b/flow/raster_cache_unittests.cc
@@ -24,6 +24,9 @@
 #include "third_party/skia/include/core/SkPicture.h"
 #include "third_party/skia/include/core/SkPictureRecorder.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -885,3 +888,5 @@ TEST_F(RasterCacheTest, RasterCacheKeyIDLayerChildrenIds) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/fml/message_loop_task_queues.cc b/fml/message_loop_task_queues.cc
@@ -15,6 +15,9 @@
 #include "flutter/fml/task_source.h"
 #include "flutter/fml/thread_local.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace fml {
 
 const size_t TaskQueueId::kUnmerged = ULONG_MAX;
@@ -397,3 +400,5 @@ TaskSource::TopTask MessageLoopTaskQueues::PeekNextTaskUnlocked(
 }
 
 }  // namespace fml
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/aiks/canvas.cc b/impeller/aiks/canvas.cc
@@ -20,6 +20,9 @@
 #include "impeller/entity/geometry/geometry.h"
 #include "impeller/geometry/path_builder.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 
 Canvas::Canvas() {
@@ -658,3 +661,5 @@ void Canvas::DrawAtlas(const std::shared_ptr<Image>& atlas,
 }
 
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/aiks/canvas_unittests.cc b/impeller/aiks/canvas_unittests.cc
@@ -6,6 +6,9 @@
 #include "impeller/aiks/canvas.h"
 #include "impeller/geometry/path_builder.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 namespace testing {
 
@@ -335,3 +338,5 @@ TEST(AiksCanvasTest, PathClipDiffAgainstFullyCoveredCullRect) {
 
 }  // namespace testing
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/archivist/archivist_unittests.cc b/impeller/archivist/archivist_unittests.cc
@@ -11,6 +11,9 @@
 #include "impeller/archivist/archive_location.h"
 #include "impeller/archivist/archivist_fixture.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 namespace testing {
 
@@ -198,3 +201,5 @@ TEST_F(ArchiveTest, CanReadWriteVectorOfArchivables) {
 
 }  // namespace testing
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/core/runtime_types.cc b/impeller/core/runtime_types.cc
@@ -9,6 +9,8 @@ namespace impeller {
 size_t RuntimeUniformDescription::GetSize() const {
   size_t size = dimensions.rows * dimensions.cols * bit_width / 8u;
   if (array_elements.value_or(0) > 0) {
+    // Covered by check on the line above.
+    // NOLINTNEXTLINE(bugprone-unchecked-optional-access)
     size *= array_elements.value();
   }
   return size;

diff --git a/impeller/display_list/dl_image_impeller.cc b/impeller/display_list/dl_image_impeller.cc
@@ -7,6 +7,9 @@
 #include "impeller/aiks/aiks_context.h"
 #include "impeller/entity/contents/filters/filter_contents.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 
 sk_sp<DlImageImpeller> DlImageImpeller::Make(std::shared_ptr<Texture> texture,
@@ -91,3 +94,5 @@ size_t DlImageImpeller::GetApproximateByteSize() const {
 }
 
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/display_list/skia_conversions.cc b/impeller/display_list/skia_conversions.cc
@@ -4,6 +4,9 @@
 
 #include "impeller/display_list/skia_conversions.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 namespace skia_conversions {
 
@@ -177,3 +180,5 @@ std::optional<impeller::PixelFormat> ToPixelFormat(SkColorType type) {
 
 }  // namespace skia_conversions
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/entity/contents/content_context.cc b/impeller/entity/contents/content_context.cc
@@ -16,6 +16,9 @@
 #include "impeller/renderer/render_target.h"
 #include "impeller/tessellator/tessellator.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 
 void ContentContextOptions::ApplyToPipelineDescriptor(
@@ -409,3 +412,5 @@ void ContentContext::SetWireframe(bool wireframe) {
 }
 
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/entity/contents/contents.cc b/impeller/entity/contents/contents.cc
@@ -15,6 +15,9 @@
 #include "impeller/renderer/command_buffer.h"
 #include "impeller/renderer/render_pass.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 
 ContentContextOptions OptionsFromPass(const RenderPass& pass) {
@@ -148,3 +151,5 @@ void Contents::SetColorSourceSize(Size size) {
 }
 
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)
diff --git a/impeller/entity/contents/filters/filter_contents.cc b/impeller/entity/contents/filters/filter_contents.cc
@@ -28,6 +28,9 @@
 #include "impeller/renderer/command_buffer.h"
 #include "impeller/renderer/render_pass.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace impeller {
 
 std::shared_ptr<FilterContents> FilterContents::MakeDirectionalGaussianBlur(
@@ -269,3 +272,5 @@ Matrix FilterContents::GetTransform(const Matrix& parent_transform) const {
 }
 
 }  // namespace impeller
+
+// NOLINTEND(bugprone-unchecked-optional-access)