[lint] Enforce kCamelCase for global constants (flutter#36175)

matanlurey · Sep 15, 2022 · b828d30 · b828d30
1 parent ccba311
commit b828d30
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -31,6 +31,8 @@ CheckOptions:
     value:  'CamelCase'
   - key:    readability-identifier-naming.EnumConstantPrefix
     value:  'k'
+  - key:    readability-identifier-naming.GlobalConstantCase
+    value:  'CamelCase'
   - key:    readability-identifier-naming.GlobalConstantPrefix
     value:  'k'
   - key:    readability-identifier-naming.PrivateMemberCase

diff --git a/lib/ui/painting/fragment_shader.cc b/lib/ui/painting/fragment_shader.cc
@@ -20,12 +20,12 @@ namespace flutter {
 
 // Since _FragmentShader is a private class, we can't use
 // IMPLEMENT_WRAPPERTYPEINFO
-static const tonic::DartWrapperInfo kDartWrapperInfo_ui_FragmentShader = {
+static const tonic::DartWrapperInfo kDartWrapperInfoUIFragmentShader = {
     "ui",
     "_FragmentShader",
 };
 const tonic::DartWrapperInfo& FragmentShader::dart_wrapper_info_ =
-    kDartWrapperInfo_ui_FragmentShader;
+    kDartWrapperInfoUIFragmentShader;
 
 std::shared_ptr<DlColorSource> FragmentShader::shader(
     DlImageSampling sampling) {

diff --git a/lib/ui/painting/image.cc b/lib/ui/painting/image.cc
@@ -18,12 +18,12 @@ namespace flutter {
 typedef CanvasImage Image;
 
 // Since _Image is a private class, we can't use IMPLEMENT_WRAPPERTYPEINFO
-static const tonic::DartWrapperInfo kDartWrapperInfo_ui_Image = {
+static const tonic::DartWrapperInfo kDartWrapperInfoUIImage = {
     "ui",
     "_Image",
 };
 const tonic::DartWrapperInfo& Image::dart_wrapper_info_ =
-    kDartWrapperInfo_ui_Image;
+    kDartWrapperInfoUIImage;
 
 CanvasImage::CanvasImage() = default;