[go: nahoru, domu]

Skip to content

Commit

Permalink
update pybind (pytorch#5067)
Browse files Browse the repository at this point in the history
Summary:
Recent update of pybind version from PyTorch (pytorch/pytorch#46415) created compatibility issue, resulting in mysterious errors like
```
__________________ TestRemoveException.test_remove_exceptions __________________
self = <tests.functionality.remove_exceptions_test.TestRemoveException testMethod=test_remove_exceptions>

    def test_remove_exceptions(self):
        """Test Glow's removeExceptions JIT pass"""

        foo_jit = torch.jit.script(foo)
        graph = foo_jit.graph
        assert graph_contains_str(graph, "prim::RaiseException")
>       torch_glow.removeExceptions_(graph)
E       TypeError: removeExceptions_(): incompatible function arguments. The following argument types are supported:
E           1. (arg0: torch::jit::Graph) -> None
```
This PR aligns the pybind11 versions in glow and pytorch, hence fixing the issue.

Documentation:

[Optional Fixes #issue]

Pull Request resolved: pytorch#5067

Test Plan: CI

Reviewed By: hl475

Differential Revision: D24912990

Pulled By: yinghai

fbshipit-source-id: ed22a8c70b51638fa11a5a172b93339563152869
  • Loading branch information
Yinghai Lu authored and facebook-github-bot committed Nov 12, 2020
1 parent 3ebd873 commit 7c7d78d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion thirdparty/pybind11
Submodule pybind11 updated 205 files
1 change: 0 additions & 1 deletion torch_glow/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ target_link_libraries(_torch_glow
PRIVATE
PyTorchModelLoader
Backends
pybind11
torch_python)

include_directories(${PYTORCH_DIR}/include)

0 comments on commit 7c7d78d

Please sign in to comment.