-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: small room optimisation of the apps/api Dockerfile image #355
base: main
Are you sure you want to change the base?
feat: small room optimisation of the apps/api Dockerfile image #355
Conversation
@Sanix-Darker feel free to assign me for reviewing when it's done! |
rm -rf /var/lib/apt/lists /var/cache/apt/archives | ||
COPY --from=prod-deps /app/node_modules /app/node_modules | ||
COPY --from=build /app /app | ||
COPY . ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copying the code here instead of line 6 like before, because, we don't need the whole source code to install all pnpm deps.
@rafaelsideguide it's ready to be reviewed... i don't have right to assign you... |
|
||
FROM base | ||
RUN apt-get update -qq && \ | ||
apt-get install --no-install-recommends -y chromium chromium-sandbox && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickscamara do we need chromium-sandbox?
BEFORE & AFTER
0.45GB of difference.