Move vcpkgTools.xml into the tool and better support for arm64-linux #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Sep 16, 2024
BillyONeal
reviewed
Sep 16, 2024
BillyONeal
reviewed
Sep 16, 2024
BillyONeal
reviewed
Sep 23, 2024
BillyONeal
reviewed
Sep 23, 2024
…ting trivial destruction.
…the search loop, and get rid of magic numbers that is the length of the table.
|
Hm I would prefer if the vcpkg-tool would get the data via a json file. With a separate file it would be easy to workaround if one of the domains is offline or otherwise broken, to replace an url with an internal version or to test a new version of a tool. |
Make the table be static data, deduplicate part of the expression in the search loop, and get rid of magic numbers that is the length of the table.
Especially updating CMake requires testing with a world rebuild before merging it. +1 on the json part since vcpkg already knows how to parse json. But yeah you are just transforming a tools.xml to a tools.json |
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Oct 10, 2024
Extracted from microsoft#1490 as it's unclear when that change will land.
BillyONeal
added a commit
that referenced
this pull request
Oct 23, 2024
Extracted from #1490 as it's unclear when that change will land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes:
vcpkgTools.xmldata into the tool. This will remove ourXMLregex parsing logic, and make it easier to add logic on what tools to install on which platforms.Related: #1277
Followup PRs:
Ninja does not support arm64 linux on vcpkg's current version. I will be making a PR to update Ninja and add architecture support for arm64 linux.