[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chipmunk] build via cmake #14776

Merged
merged 5 commits into from
Dec 4, 2020
Merged

[Chipmunk] build via cmake #14776

merged 5 commits into from
Dec 4, 2020

Conversation

comedinha
Copy link
Contributor

Actually the chipmunk only can build via msvc, this change will allow build via cmake.

@comedinha comedinha changed the title Chipmunk build via cmake [Chipmunk ] build via cmake Nov 25, 2020
@comedinha comedinha changed the title [Chipmunk ] build via cmake [Chipmunk] build via cmake Nov 25, 2020
@NancyLi1013 NancyLi1013 self-assigned this Nov 26, 2020
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 26, 2020
NancyLi1013
NancyLi1013 suggested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor
@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might try to remove msbuild part and verify if it can build fine on Windows via CMake.

ports/chipmunk/portfile.cmake Outdated Show resolved Hide resolved
ports/chipmunk/portfile.cmake Outdated Show resolved Hide resolved
ports/chipmunk/portfile.cmake Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Please also update version in CONTROl file.

@comedinha
Copy link
Contributor Author

@NancyLi1013 changes made.

@NancyLi1013
Copy link
Contributor

You might try to remove msbuild part and verify if it can build fine on Windows via CMake.

Have you tried to build via CMake on all platforms?

@comedinha
Remove msbuild
9fef9c5 
Back ARM builds to baseline
@comedinha
Copy link
Contributor Author

You might try to remove msbuild part and verify if it can build fine on Windows via CMake.

Have you tried to build via CMake on all platforms?

Yeah, tested and fixed for x64 UWP

NancyLi1013
NancyLi1013 suggested changes Dec 2, 2020
View reviewed changes
ports/chipmunk/portfile.cmake Outdated Show resolved Hide resolved
ports/chipmunk/portfile.cmake Outdated Show resolved Hide resolved
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@comedinha
Arm support
94d7407 
Kept consistent on portfile
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2020
@NancyLi1013
Copy link
Contributor

LGTm now, thanks for your PR @comedinha.

@BillyONeal BillyONeal merged commit 222f276 into microsoft:master Dec 4, 2020
@BillyONeal
Copy link
Member

Awesome, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comedinha @NancyLi1013 @BillyONeal