[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kuku] Add new port #14898

Merged
merged 3 commits into from
Dec 5, 2020
Merged

[kuku] Add new port #14898

merged 3 commits into from
Dec 5, 2020

Conversation

kiromaru
Copy link
Contributor
@kiromaru kiromaru commented Dec 2, 2020

Add new port for kuku library:
https://github.com/microsoft/Kuku

  • What does your PR fix?
    This is a new port

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Tested x86-windows, x86-windows-static, x64-windows, x64-windows-static, x64-linux, x64-osx. Other triplets should be supported as well.
    I have not updated the CI baseline.

  • Does your PR follow the maintainer guide?
    Yes

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 2, 2020
PhoebeHui
PhoebeHui requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor
@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please ignore the CI failures, it doesn't relate to this changes.

ports/kuku/CONTROL Outdated Show resolved Hide resolved
@kiromaru
Copy link
Contributor Author
kiromaru commented Dec 2, 2020

I've removed the empty Default-Features entry.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2020
@BillyONeal BillyONeal merged commit 0b769ed into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiromaru @BillyONeal @PhoebeHui @JackBoosY