[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal inline chat should not have it own menu #208789

Closed
bpasero opened this issue Mar 26, 2024 · 3 comments
Closed

Terminal inline chat should not have it own menu #208789

bpasero opened this issue Mar 26, 2024 · 3 comments
Assignees
@meganrogge
Labels
debt Code quality issues terminal-chat Issues related to the terminal chat widget
Milestone
April 2024

Comments

@bpasero
Copy link
Member
bpasero commented Mar 26, 2024

Currently, the voice actions have to contribute to the terminalChatInput menu, but all other cases work with the MenuId.ChatExecute, so I wonder why the terminal inline chat is so special that it has its own menu.
@Tyriar
Copy link
Member
Tyriar commented Mar 26, 2024

Guessing we can switch this now

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-chat Issues related to the terminal chat widget labels Mar 26, 2024
@Tyriar Tyriar added this to the April 2024 milestone Mar 26, 2024
@meganrogge
Copy link
Contributor

Starting looking into this. If we use the MenuId.ChatExecute, then we also have to use the submit action here, which doesn't work for us since it uses an editor instead of a terminal. we could add TerminalChatController here 🤔 but that complicates things...

vscode/src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

Lines 149 to 168 in 3dc6e72

keybinding: {
when: CONTEXT_IN_CHAT_INPUT,
primary: KeyCode.Enter,
weight: KeybindingWeight.EditorContrib
},
menu: {
id: MenuId.ChatExecuteSecondary,
when: CONTEXT_CHAT_REQUEST_IN_PROGRESS.negate(),
group: 'group_1',
},
});
}
runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor): void | Promise<void> {
const editorUri = editor.getModel()?.uri;
if (editorUri) {
const widgetService = accessor.get(IChatWidgetService);
widgetService.getWidgetByInputUri(editorUri)?.acceptInput();
}
}

meganrogge added a commit that referenced this issue Apr 1, 2024
@meganrogge
wip #208789
ede0036
@Tyriar Tyriar added the debt Code quality issues label Apr 8, 2024
@Tyriar Tyriar removed their assignment Apr 17, 2024
@meganrogge
Copy link
Contributor

It would be nice if we could do this. I couldn't figure out a way given the above.

@meganrogge meganrogge removed the bug Issue identified by VS Code Team member as probable bug label Apr 18, 2024
@meganrogge meganrogge mentioned this issue Jun 4, 2024
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
debt Code quality issues terminal-chat Issues related to the terminal chat widget
Projects
None yet
Milestone
April 2024
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @meganrogge