[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit showFoldingControls to have a never setting #153764

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Edit showFoldingControls to have a never setting #153764

merged 1 commit into from
Jul 7, 2022

Conversation

jzyrobert
Copy link
Contributor

This PR fixes #58708

Demo:

vcxsrv_CBxfgCEEuk.mp4
  • Add 'never' as a setting with a description to both editor.showFoldingControls and notebook.showFoldingControls
  • Ensure lineDecorationWidth is updated with the setting
  • Don't show visible folding decorations when set to never

Of consideration:

  • Should the setting actually remove the folding decorations instead of using the hidden one? Does anything depend on the decorations assumed to be there?
  • I edited commentsEditorContribution for the gutter size but I don't actually know what this does/how to open this "comment editor"
  • What kind of tests could be added for this?

@aeschli aeschli self-requested a review July 6, 2022 15:01
@aeschli aeschli added this to the July 2022 milestone Jul 6, 2022
@aeschli
Copy link
Contributor
aeschli commented Jul 6, 2022

Great job!

We still need the decoration to track the updated ranges.
I also tested the editor with comments.

Adding @rebornix for reviewing the notebook changes

@aeschli aeschli requested a review from rebornix July 6, 2022 15:07
rebornix
rebornix approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member
@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aeschli aeschli merged commit e337c02 into microsoft:main Jul 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2022
@jzyrobert jzyrobert deleted the jzyrobert/editor_folding_never branch April 18, 2024 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

[folding] editor.showFoldingControls: never
3 participants
@jzyrobert @aeschli @rebornix