Correct initial window size on Windows secondary display with different scaling factor (#146499) #155589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deepak1556 I hope this PR can be approved and merged in time for endgame next week. |
|
@bpasero the fix here was to apply the same logic on Windows as you added in #74872 for Mac. If @deepak1556 isn't able to review this in time for endgame maybe you could? |
|
I cannot test this unfortunately because I have no Windows machine (other than a VM where I am not sure I can do multi monitor setup). And I would not do this so late in the endgame, so let me move this to August and try to get a machine meanwhile. |
bpasero
approved these changes
Aug 2, 2022
|
Thanks! Let's merge this in to insiders early to gather feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #146499