Add shift resource bindings in Vulkan #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed issue packMatricesInRowMajor is inverted
|
Hi @gongminmin |
|
I restart the CI but it's still fail. The problem is you need to update the expected test results under Source\Tests\Data\Expected to reflect your changes to -Zpr. |
gongminmin
reviewed
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gongminmin ,
I added 4 new parameters in Options struct:
int shiftAllTexturesBindings: First binding number for Vulkan textures.
int shiftAllSamplersBindings: First binding number for Vulkan samplers.
int shiftAllCBuffersBindings: First binding number for Vulkan constant buffers.
int shiftAllUABuffersBindings: First binding number for Vulkan unordered access buffers.
It is equivalent to use -fvk-{b|s|t|u}-shift in DXC command-line. That is a very important option when you compile HLSL to SPIRV HLSL register and Vulkan binding.
Finally, I inverted packMatricesInRowMajor option to fix the issue.
Resolve #37
Resolve #41