[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyQt6 support #1549

Merged
merged 2 commits into from
Jul 31, 2024
Merged

PyQt6 support #1549

merged 2 commits into from
Jul 31, 2024

Conversation

wmvanvliet
Copy link
Contributor

This adds support for interactive matplotlib figures using the qt6 backend. The code could really use some de-duplication (it defines the list of possible qt backends more than 10 times all over the place) and the docstrings need some love too. But it seems to work.

fixes #1112

@wmvanvliet
Copy link
Contributor Author

@microsoft-github-policy-service agree

@SebusFu
Copy link
SebusFu commented Jul 24, 2024

Hi, is there any update here? I can't get debugging to work on macOS using PySide6 and Matplotlib, with all mentioned tricks. Or is there any other hint I am overseeing?

@rchiodo
Copy link
Contributor
rchiodo commented Jul 24, 2024

@wmvanvliet can you close and reopen? Not sure why the lint portion is waiting but I don't think it's going to run since it's been waiting for 4 months.

@wmvanvliet wmvanvliet closed this Jul 24, 2024
@wmvanvliet wmvanvliet reopened this Jul 24, 2024
@wmvanvliet wmvanvliet requested a review from a team as a code owner July 24, 2024 18:42
@wmvanvliet wmvanvliet closed this Jul 24, 2024
@wmvanvliet wmvanvliet reopened this Jul 24, 2024
@wmvanvliet
Copy link
Contributor Author

The linting is not running because it requires approval from a maintainer.

@AdamYoblick
Copy link
Member

/AzurePipelines run

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@AdamYoblick
Copy link
Member

It's running now :) We have to manually run it with /azp run when it comes from a fork, for security reasons.

@rchiodo
Copy link
Contributor
rchiodo commented Jul 24, 2024

@AdamYoblick does this test failure look like the flakey test you added retry to? Maybe we need to merge this branch with main?

@rchiodo
Copy link
Contributor
rchiodo commented Jul 24, 2024

/AzurePipelines run

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@AdamYoblick
Copy link
Member

@AdamYoblick does this test failure look like the flakey test you added retry to? Maybe we need to merge this branch with main?

Yes, it does look similar. Test workers crashing. Although I don't think merging main in will make a difference in this case because the test I marked as flaky was not the test method that failed here (test_log_dir_env). Unfortunately, we probably need to mark more tests as flaky. I don't remember 100% but I think that it was only python 3.12 on windows crashing before, just like in this case.

I wonder if we just need to mark the entire test suite as flaky with retries until this is properly investigated.

@int19h
Copy link
Contributor
int19h commented Jul 24, 2024

This one is a pytest crash reading from a socket, so likely to be environment-induced.

In general I recall two main categories of flaky tests. One was anything to do with attach-to-PID, and specific to tests that do that. The other is a general failure when sockets just get randomly closed or timed out, which I have only ever seen in CI and not locally, but can happen with almost every test (since anything that runs debugpy involves sockets); I always suspected it is also something coming from the environment for those runs but I never saw any clues as to what it could be.

@SebusFu
Copy link
SebusFu commented Jul 29, 2024

Thank you all for taking care, may I please ask if approved now (If I understand correctly?), when it can be released? Or how can I help to test e.g. in my environment?

@AdamYoblick
Copy link
Member

@SebusFu - You don't have to wait for a debugpy release to be able to test the changes. Here's what you do:

  1. Clone or fork the repo (which you already have)
  2. Add the following line to your launch configuration in launch.json:

"debugAdapterPath": "<path_to_your_fork>/src/debugpy/adapter"

  1. Launch the file

This will use your local debugpy source instead of the debugpy that comes installed with the Python Core Extension, and you can see if it works.

Thanks!

@SebusFu
Copy link
SebusFu commented Jul 31, 2024

Thank you very much, works like a charm now for me!

@AdamYoblick
Copy link
Member

/azp run

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@AdamYoblick
Copy link
Member

This test fail has nothing to do with your changes, it's a flaky test, so I'm going to merge this in.

@AdamYoblick AdamYoblick merged commit dc58df1 into microsoft:main Jul 31, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pyqt6
5 participants