[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcut for joining segments #1478

Closed
4 tasks done
hulleyrob opened this issue Feb 17, 2023 · 4 comments
Closed
4 tasks done

Keyboard Shortcut for joining segments #1478

hulleyrob opened this issue Feb 17, 2023 · 4 comments

Comments

@hulleyrob
Copy link

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Description

I find myself wanting to join segments often, I cannot find a shortcut for this so my idea is 2 shortcuts.

  1. Join current segment (selected) with the segment to the LEFT.
  2. Join current segment (selected) with the segment to the RIGHT.

Would this be a useful feature for anyone else?

To make this more clear what I am doing is using the detect scene change feature and then joining some segments that belong to either the longer left or right segment.

Related to this workflow it would be useful if clear all segments was in the tools menu with detect scene changes etc OR that the menu that has been run becomes UNDO scene changes to make it easier when trying to find a good value for said function.

Thanks
Rob

mifi added a commit that referenced this issue Feb 18, 2023
for "combine overlapping segments" #1478
@mifi
Copy link
Owner
mifi commented Feb 18, 2023

I added now a keyboard action for the menu item "combine overlapping segments".

But reading your request again, I think what you want is something different, am I right? You don't want to join overlapping segment, but you want to selectively join neighbouring segments? as in neighbouring in time, not neighbours in order (1,2,3)?

maybe that could be implemented in a more flexible way by using the existing "select segments" functionaliuty, then another function and shortcut for "join all selected segments". Then I think we would need keyboard shortcuts also for these actions:

  • "select current segment"
  • "deselect current segment"

@hulleyrob
Copy link
Author

A picture here may help.

image

Now from searching through with CMD+Right Arrow I know that 12 and 13 should actually be the same segment that I want to export.

My idea is CMD + ] if on segment 12 will join it with segment 13 to make a longer segment 12.

If I was in segment 13 and press CMD + [ it would effectively do the same thing but join the previous segment in this case.

Are the overlapping segments you mentioned the lighter parts either side of segment 12? I had not even realised there may be such a thing.

@mifi
Copy link
Owner
mifi commented Apr 4, 2023

Are the overlapping segments you mentioned the lighter parts either side of segment 12? I had not even realised there may be such a thing.

no the lighter parts are just a way to highlight the end of the segments.

I'm not sure if I'm going to implement custom shortcuts for combining current segment with the next. but I've implemented a new shortcut for "Combine selected segments". If you use this sequence of keyboard actions i think you can get a good workflow:

  1. "Deselect all segments"
  2. "Toggle current segment selected"
  3. "Jump to next segment" / "Jump to previous segment"
  4. "Toggle current segment selected"
  5. "Combine selected segments"

closing this for now.

@mifi mifi closed this as completed in 59cd930 Apr 4, 2023
@hulleyrob
Copy link
Author

Thanks will give it a go, appreciate your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants