test: add vulture to detect dead code

Part of the pre-commit stack, so we prevent it from sneaking in. Signe-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman · Jul 18, 2022 · 7ba12ac · 7ba12ac
1 parent 2186e26
commit 7ba12ac
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -29,3 +29,7 @@ repos:
     hooks:
     -   id: pyupgrade
         args: [--py37-plus]
+-   repo: https://github.com/jendrikseipp/vulture
+    rev: 'v2.5'
+    hooks:
+    -   id: vulture
diff --git a/pyproject.toml b/pyproject.toml
@@ -58,6 +58,11 @@ known_first_party = ['pytest_socket', 'conftest', 'test_socket']
 # https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#profilegcm
 profile = "black"
 
+[tool.vulture]
+ignore_decorators = ["@pytest.fixture"]
+ignore_names = ["pytest_*"]
+paths = ["pytest_socket.py"]
+
 [build-system]
 requires = ["poetry-core>=1.0.0"]
 build-backend = "poetry.core.masonry.api"
diff --git a/pytest_socket.py b/pytest_socket.py
@@ -7,12 +7,12 @@
 
 
 class SocketBlockedError(RuntimeError):
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *_args, **_kwargs):
         super().__init__("A test tried to use socket.socket.")
 
 
 class SocketConnectBlockedError(RuntimeError):
-    def __init__(self, allowed, host, *args, **kwargs):
+    def __init__(self, allowed, host, *_args, **_kwargs):
         if allowed:
             allowed = ",".join(allowed)
         super().__init__(