-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@pytest.mark.enable_socket doesn't work #15
Comments
There seems to be a test for this: https://github.com/miketheman/pytest-socket/blob/0.3.1/tests/test_socket.py#L104-L115 But it looks like it's asserting on the exact opposite of what it should be asserting.. |
A few tests for enabled sockets had inverted success criteria. Issue miketheman#15 is resolved by prioritizing the pytest markers over the CLI config.
A few tests for enabled sockets had inverted success criteria. Issue miketheman#15 is resolved by prioritizing the pytest markers over the CLI config. Signed-off-by: Calvin Behling <calvin.behling@gmail.com>
@miketheman - any update on #28 ? :) would be nice to fix, we just ran into this Adding latest information, still an issue with these versions:
|
I'll try to get to evaluating these scenarios and fix this weekend. |
Workaround:
gives
works |
A few tests for enabled sockets had inverted success criteria. Issue miketheman#15 is resolved by prioritizing the pytest markers over the CLI config. Signed-off-by: Calvin Behling <calvin.behling@gmail.com>
A few tests for enabled sockets had inverted success criteria. Issue miketheman#15 is resolved by prioritizing the pytest markers over the CLI config. Signed-off-by: Calvin Behling <calvin.behling@gmail.com>
As reported in a couple of issues, the usage of markers (not fixtures) was misbehaving, as the order in which the `_socket_marker` evaluation was occurring left the command-line option disabled. Fixes #15 Closes #28 Co-authored-by: Calvin Behling <calvin.behling@gmail.com> Signed-off-by: Albert Tugushev <albert@tugushev.ru> Signed-off-by: Matt Callaghan <mcallaghan-bsm@users.noreply.github.com> Signed-off-by: Mike Fiedler <miketheman@gmail.com>
As reported in a couple of issues, the usage of markers (not fixtures) was misbehaving, as the order in which the `_socket_marker` evaluation was occurring left the command-line option disabled. Fixes #15 Closes #28 Co-authored-by: Calvin Behling <calvin.behling@gmail.com> Signed-off-by: Albert Tugushev <albert@tugushev.ru> Signed-off-by: Matt Callaghan <mcallaghan-bsm@users.noreply.github.com> Signed-off-by: Mike Fiedler <miketheman@gmail.com>
The mark to
enable_socket
doesn't seem to work. The fixturesocket_enabled
still works.Tried also on
pytest==3.6.3
(earliest version supported according to pytest-socket metadata), same result.MCVE
test_something.py
:Demo:
The text was updated successfully, but these errors were encountered: