[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: align chart properties with naming convention #17065

Merged

Conversation

dnskr
Copy link
Contributor
@dnskr dnskr commented Apr 23, 2023

Description

The PR aligns chart property names with Helm naming convention:

Variable names should begin with a lowercase letter, and words should be separated with camelcase

It seems to be a breaking change, so it might be a good idea to fail the chart installation/upgrade if old property names are used, for example:

  {{- if .Values.persistence.VolumeName }}
  {{- fail "Property 'persistence.VolumeName' is deprecated, use 'persistence.volumeName' instead" }}
  {{- end }}

Motivation and Context

Keep code cleaner by following common naming convention.

How to test this PR?

Install the chart using new property names.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

@harshavardhana harshavardhana merged commit b963f69 into minio:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants