[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove active healing on .minio.sys/ during startup #17072

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix: remove active healing on .minio.sys/ during startup #17072

merged 1 commit into from
Apr 29, 2023

Conversation

harshavardhana
Copy link
Member

Description

fix: remove active healing on .minio.sys/ during startup

Motivation and Context

The number of listing calls this can start can easily overwhelm
the server and add to latencies upon startup on a large setup.
With the change in PR #17004 - we have no reason to heal or
migrate old formats.

We can always read and let them be overwritten in time.

How to test this PR?

Nothing special, this should not affect any functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana force-pushed the improve-migration-further branch 2 times, most recently from 686e443 to 541fc15 Compare April 25, 2023 05:39
@harshavardhana harshavardhana changed the title fix: remove active healing on .minio.sys/ during startup [draft] fix: remove active healing on .minio.sys/ during startup Apr 25, 2023
@harshavardhana harshavardhana changed the title [draft] fix: remove active healing on .minio.sys/ during startup ix: remove active healing on .minio.sys/ during startup Apr 26, 2023
@harshavardhana harshavardhana changed the title ix: remove active healing on .minio.sys/ during startup fix: remove active healing on .minio.sys/ during startup Apr 26, 2023
vadmeste
vadmeste approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member
@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana
fix: remove active healing on .minio.sys/ during startup
4a40af5 
The number of listing calls this can start can easily overwhelm
the server and add to latencies upon startup on a large setup.
With the change in PR minio#17004 - we have no reason to heal or
migrate old formats.

We can always read and let them be overwritten in time.
@harshavardhana harshavardhana merged commit 02d8f3c into minio:master Apr 29, 2023
@harshavardhana harshavardhana deleted the improve-migration-further branch April 29, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@poornas poornas poornas approved these changes

@krisis krisis Awaiting requested review from krisis

Assignees
No one assigned
Labels
performance/optimize
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshavardhana @vadmeste @poornas @bh4t