[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: declare missing properties in values.yaml #17153

Merged

Conversation

dnskr
Copy link
Contributor
@dnskr dnskr commented May 6, 2023

Description

The PR declares missing properties used by the chart with empty values in values.yaml.
The PR does not change any functionality of the chart.

Motivation and Context

The changes improve self-documentation of the chart where values.yaml is used as a single point of truth for configuration capabilities.

How to test this PR?

Check that chart templates rendered with default values are identical before and after the changes:

git checkout master
helm template minio-test helm/minio >> 111.txt

git checkout declare_missing_chart_properties
helm template minio-test helm/minio >> 222.txt

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit be18d43 into minio:master May 6, 2023
@bh4t bh4t added the bugfix label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants