clarify error message for root user credential #20043
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to be simplified its changing too many things. |
d5ec965
to
38dd31c
Compare
|
Sorry I'm new to this project. I just pushed another version which only changes the error displayed when |
cmd/common-main.go
Outdated
| @@ -851,6 +852,7 @@ func loadRootCredentials() { | |||
| } else if env.IsSet(config.EnvAccessKey) && env.IsSet(config.EnvSecretKey) { | |||
| user = env.Get(config.EnvAccessKey, "") | |||
| password = env.Get(config.EnvSecretKey, "") | |||
| isUsingKeys = true | |||
There was a problem hiding this comment.
Suggested change
| isUsingKeys = true | |
| legacyCredentials = true |
|
the new PR looks good. |
MINIO_ACCESS_KEY and MINIO_SECRET_KEY is prompted as deprecated when set in enviroment variables. The error message on failure of credential check still shows "access key" and "secret key", which confuses users. This patch clarifies error messages for these cases so that it matches the actual failure reason. Signed-off-by: Austin Chang <austin880625@gmail.com>
38dd31c
to
a047302
Compare
|
I've just updated the naming. Thank for the review |
harshavardhana
approved these changes
Jul 10, 2024
|
Oops sorry I was using the phone and touched the "merge master" button unintentionally, should we restart the pipeline or I need to force push again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Clarifies error messages for root user credential environment variables so that it matches the actual failure reason.
Motivation and Context
MINIO_ACCESS_KEY and MINIO_SECRET_KEY is prompted as deprecated when set in enviroment variables. The error message on failure of credential check still shows "access key" and "secret key", which confuses users.
How to test this PR?
start minio server with MINIO_ROOT_USER and MINIO_ROOT_PASSWORD set and violate the length requirements
Types of changes
Checklist:
commit-idorPR #here)