[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_client_can_be_serialized_with_pickle #10927

Merged

Conversation

harupy
Copy link
Member
@harupy harupy commented Jan 29, 2024
馃洜 DevTools 馃洜

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10927/merge

Checkout with GitHub CLI

gh pr checkout 10927

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Fixes this error https://github.com/mlflow/mlflow/actions/runs/7691119289/job/20955938381/

It looks like _tracking_store_registry is somehow copied (by pytest?), the original _tracking_store_registry doesn't know about pickle and complains "I don't know pickle":

Code:

        _tracking_store_registry.register("pickle", lambda *args, **kwargs: mock_tracking_store)
        _get_model_registry_store_registry().register(
            "pickle", lambda *args, **kwargs: mock_model_registry_store
        )
    
        # Create an MlflowClient with the store that cannot be pickled, perform
        # tracking & model registry operations, and verify that the client can still be pickled
>       client = MlflowClient("pickle://foo")

Error:

E           mlflow.tracking.registry.UnsupportedModelRegistryStoreURIException:  Model registry functionality is unavailable; got unsupported URI 'pickle://foo' for model registry data storage. Supported URI schemes are: ['', 'file', 'databricks', 'databricks-uc', 'http', 'https', 'postgresql', 'mysql', 'sqlite', 'mssql', 'file-plugin']. See https://www.mlflow.org/docs/latest/tracking.html#storage for how to run an MLflow server against one of the supported backend storage locations.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Jan 29, 2024
Copy link
github-actions bot commented Jan 29, 2024

Documentation preview for 16906fb will be available here when this CircleCI job completes successfully.

More info

@harupy harupy requested review from a team, mahesh-venkatachalam, BenWilson2 and dbczumar and removed request for mahesh-venkatachalam, BenWilson2, dbczumar and a team January 29, 2024 08:42
Copy link
Collaborator
@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy force-pushed the fix_test_client_can_be_serialized_with_pickle branch from 24f6049 to 16906fb Compare January 29, 2024 09:35
@harupy harupy removed the request for review from a team January 29, 2024 10:07
@harupy harupy merged commit 065f543 into mlflow:master Jan 29, 2024
34 of 36 checks passed
@harupy harupy deleted the fix_test_client_can_be_serialized_with_pickle branch January 29, 2024 10:08
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Feb 6, 2024
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
daniellok-db pushed a commit that referenced this pull request Feb 6, 2024
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fail-fast rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants