[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle AWS encryption details #12495

Merged
merged 10 commits into from
Jul 10, 2024
+505 −237
Merged

Handle AWS encryption details #12495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f1f2482
handle aws encryption details
artjen Jun 26, 2024
eee7f7c
fix lint
artjen Jun 27, 2024
d09c97c
Merge remote-tracking branch 'base/master' into handle-aws-encryption…
mlflow-automation Jun 27, 2024
c307295
Autoformat: https://github.com/mlflow/mlflow/actions/runs/9689533222
mlflow-automation Jun 27, 2024
e332c67
retrigger tests
artjen Jun 27, 2024
32f1594
fix tests
artjen Jun 27, 2024
d8bd736
add tests
artjen Jul 9, 2024
88b08d3
Merge branch 'master' into handle-aws-encryption-details
artjen Jul 9, 2024
5e692f6
empty commit retrigger tests
artjen Jul 9, 2024
248ea62
Merge branch 'master' into handle-aws-encryption-details
artjen Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests 
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
  • Loading branch information
@artjen
artjen committed Jun 27, 2024
commit 32f15947cf8aa62f363cab1be9c0c54d7528a7ff
4 changes: 4 additions & 0 deletions tests/store/_unity_catalog/model_registry/test_unity_catalog_rest_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ def test_create_model_version_with_langchain_dependencies(store, langchain_local
secret_access_key=secret_access_key,
session_token=session_token,
credential_refresh_def=ANY,
s3_upload_extra_args={},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to add a test/mock around this not being empty every time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests in d8bd736

)
mock_artifact_repo.log_artifacts.assert_called_once_with(local_dir=ANY, artifact_path="")
_assert_create_model_version_endpoints_called(
Expand Down Expand Up @@ -377,6 +378,7 @@ def test_create_model_version_with_resources(store, langchain_local_model_dir_wi
secret_access_key=secret_access_key,
session_token=session_token,
credential_refresh_def=ANY,
s3_upload_extra_args={},
)
mock_artifact_repo.log_artifacts.assert_called_once_with(local_dir=ANY, artifact_path="")
_assert_create_model_version_endpoints_called(
Expand Down Expand Up @@ -434,6 +436,7 @@ def test_create_model_version_with_langchain_no_dependencies(
secret_access_key=secret_access_key,
session_token=session_token,
credential_refresh_def=ANY,
s3_upload_extra_args={},
)
mock_artifact_repo.log_artifacts.assert_called_once_with(local_dir=ANY, artifact_path="")
_assert_create_model_version_endpoints_called(
Expand Down Expand Up @@ -1019,6 +1022,7 @@ def test_create_model_version_aws(store, local_model_dir):
secret_access_key=secret_access_key,
session_token=session_token,
credential_refresh_def=ANY,
s3_upload_extra_args={},
)
mock_artifact_repo.log_artifacts.assert_called_once_with(local_dir=ANY, artifact_path="")
_assert_create_model_version_endpoints_called(
Expand Down
1 change: 1 addition & 0 deletions tests/store/artifact/test_unity_catalog_models_artifact_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def test_uc_models_artifact_repo_download_artifacts_uses_temporary_creds_aws(mon
secret_access_key=fake_secret_access_key,
session_token=fake_session_token,
credential_refresh_def=ANY,
s3_upload_extra_args={},
)
mock_s3_repo.download_artifacts.assert_called_once_with("artifact_path", "dst_path")
request_mock.assert_called_with(
Expand Down
Loading