Update NeighborSearch: Switching l-rvalue reference overload to pass-by-value #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcurtin
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
Hey there, thanks! This looks great. I don't see any issues with it at all. I will go ahead and merge it in 3 days, to leave time for other comments.
If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt, please feel free. Also, if you like, I can mail you mlpack stickers that you can put on your laptop. If you'd like some, just send me an email with your mailing address to ryan@ratml.org.
Thanks again for the nice contribution!
|
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching lvalue reference and rvalue reference overload to pass-by-value argument in the Neighbor Search algorithm, as suggested at #1021 issue.
A user can pass the data by making a copy (Method(data)) or, avoiding copies if possible, by moving the data into the method (Method(std::move(data))).