[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiving multiple ACK ranges makes later ACK ranges not count towards cwnd due to app_limited #1475

Closed
mb opened this issue Oct 19, 2023 · 1 comment · Fixed by #1479
Closed

Comments

@mb
Copy link
Collaborator
mb commented Oct 19, 2023

Last observation from graphs in #1472. I created multiple issues because I think they can be fixed separately.

We receive ack range covering ~10 packets at a time and call on_packets_acked on each ack range. The first one is not app_limited, but because we don't send out enough packets right away (none to be specific), all consecutive ack ranges don't count towards the cwnd. In my testing during the recovery phase 7153 out of 25839 acks were app_limited (27.68%) due to this.

@mb
Copy link
Collaborator Author
mb commented Oct 24, 2023

Note to self, possible fix: count as non-app-limit in ack when non-app-limit detected during sent in last rtt

mb added a commit to mb/neqo that referenced this issue Oct 26, 2023
mb added a commit to mb/neqo that referenced this issue Oct 26, 2023
mb added a commit to mb/neqo that referenced this issue Oct 26, 2023
mb added a commit to mb/neqo that referenced this issue Oct 27, 2023
mb added a commit to mb/neqo that referenced this issue Oct 27, 2023
mb added a commit to mb/neqo that referenced this issue Nov 2, 2023
mb added a commit to mb/neqo that referenced this issue Nov 20, 2023
mb added a commit to mb/neqo that referenced this issue Nov 20, 2023
@mb mb closed this as completed in #1479 Nov 20, 2023
mb added a commit that referenced this issue Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant