[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgx Logger and Connection Updates #2124

Merged
merged 12 commits into from
Jun 13, 2024
Merged

pgx Logger and Connection Updates #2124

merged 12 commits into from
Jun 13, 2024

Conversation

nickzelei
Copy link
Member
@nickzelei nickzelei commented Jun 12, 2024 •
edited
Loading
  • Adds ability to enable pgx logging. For Postgres, you can now see SQL queries if you run neosync api/worker with a LOG_LEVEL=DEBUG
  • Centralizes the logger module that the worker+backend were using. Previously they were separate, updates to use the same logic
  • Fixes the job run status badge. Didn't realize it was used in multiple places and fixed the weirdness that was present on the run id page
  • Updates pgx to no longer use prepared statements as this doesn't work well with pgbouncer.

@vercel Vercel
Copy link
vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 11:49pm

@codecov Codecov
Copy link
codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.07317% with 68 lines in your changes missing coverage. Please review.

Project coverage is 17.71%. Comparing base (d8f104e) to head (758374a).
Report is 10 commits behind head on main.

Files Patch % Lines
backend/internal/pgx-slog/adapter.go 22.58% 24 Missing ⚠️
backend/pkg/logger/logger.go 0.00% 14 Missing ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 8 Missing ⚠️
backend/internal/nucleusdb/db.go 0.00% 8 Missing ⚠️
backend/pkg/sqlconnect/pgpool.go 0.00% 8 Missing ⚠️
backend/pkg/sqlmanager/sql-manager.go 75.00% 1 Missing and 1 partial ⚠️
worker/internal/cmds/worker/serve/serve.go 0.00% 2 Missing ⚠️
...atasync/activities/gen-benthos-configs/activity.go 0.00% 1 Missing ⚠️
...nc/activities/run-sql-init-table-stmts/activity.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2124   +/-   ##
=======================================
  Coverage   17.70%   17.71%           
=======================================
  Files         222      222           
  Lines       49382    49435   +53     
=======================================
+ Hits         8744     8756   +12     
- Misses      39540    39580   +40     
- Partials     1098     1099    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 7f8fb18 into main Jun 13, 2024
13 of 14 checks passed
@nickzelei nickzelei deleted the nick/logger-updates branch June 13, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nickzelei