[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1208 add gcp cloud storage to connections backend #2206

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link
linear bot commented Jun 25, 2024

Copy link
vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 8:24pm

@nickzelei nickzelei marked this pull request as ready for review June 25, 2024 20:19
Copy link
codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 4.37500% with 153 lines in your changes missing coverage. Please review.

Project coverage is 19.41%. Comparing base (dd74ee7) to head (ac8dd25).
Report is 3 commits behind head on main.

Current head ac8dd25 differs from pull request most recent head d636c9f

Please upload reports for the commit d636c9f to get more accurate results.

Files Patch % Lines
.../go/protos/mgmt/v1alpha1/connection.pb.validate.go 0.00% 68 Missing ⚠️
...ckend/gen/go/protos/mgmt/v1alpha1/connection.pb.go 10.76% 57 Missing and 1 partial ⚠️
backend/sql/postgresql/models/models.go 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2206      +/-   ##
==========================================
- Coverage   19.46%   19.41%   -0.06%     
==========================================
  Files         229      229              
  Lines       50743    50886     +143     
==========================================
+ Hits         9879     9881       +2     
- Misses      39607    39746     +139     
- Partials     1257     1259       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 9b3a671 into main Jun 25, 2024
15 checks passed
@nickzelei nickzelei deleted the nick/neos-1208-add-gcs-support-to-backendworker branch June 25, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant