[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1211 add gcs cloud storage support to cli #2221

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link
linear bot commented Jun 27, 2024

Copy link
vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 10:30pm

Copy link
codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 4.93562% with 443 lines in your changes missing coverage. Please review.

Project coverage is 19.23%. Comparing base (6d39be9) to head (42f2fc1).
Report is 6 commits behind head on main.

Files Patch % Lines
...rotos/mgmt/v1alpha1/connection_data.pb.validate.go 0.00% 170 Missing ⚠️
backend/internal/gcp/client.go 0.00% 168 Missing ⚠️
...1alpha1/connection-data-service/connection-data.go 26.82% 58 Missing and 2 partials ⚠️
cli/internal/cmds/neosync/sync/sync.go 0.00% 24 Missing ⚠️
...internal/benthos/inputs/neosync-connection-data.go 0.00% 12 Missing ⚠️
backend/internal/gcp/manager.go 0.00% 7 Missing ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2221      +/-   ##
==========================================
- Coverage   19.38%   19.23%   -0.15%     
==========================================
  Files         229      231       +2     
  Lines       51041    51636     +595     
==========================================
+ Hits         9892     9934      +42     
- Misses      39884    40428     +544     
- Partials     1265     1274       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review June 27, 2024 22:33
@nickzelei nickzelei merged commit caaf0cb into main Jun 27, 2024
13 of 15 checks passed
@nickzelei nickzelei deleted the nick/neos-1211-add-gcs-cloud-storage-support-to-cli branch June 27, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant