Remove composer dependency, insights, and tests #575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's recommended in #559 that we remove the
composer/composer
dependency. There is still aSemvar
dependency, but that seemed to be connected to a few more things, but the surface area is much smaller, so I decided to keep it and not take out those instances.IMO the composer checks that I removed don't carry a lot of value for the number of conflicts and bugs that the package has been getting on install/update, so I think we'd be better off removing them.