uberf-7350: add more oauth logs (hcengineering#5879)

naif0s · Jun 21, 2024 · adb2866 · adb2866
1 parent 182d108
commit adb2866
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/pods/authProviders/src/github.ts b/pods/authProviders/src/github.ts
@@ -38,7 +38,7 @@ export function registerGithub (
   router.get('/auth/github', async (ctx, next) => {
     measureCtx.info('try auth via', { provider: 'github' })
     const host = getHost(ctx.request.headers)
-    const branding = host !== undefined ? brandings[host]?.key ?? '' : ''
+    const branding = host !== undefined ? brandings[host]?.key ?? undefined : undefined
     const state = encodeURIComponent(
       JSON.stringify({
         inviteId: ctx.query?.inviteId,

diff --git a/pods/authProviders/src/google.ts b/pods/authProviders/src/google.ts
@@ -38,7 +38,7 @@ export function registerGoogle (
   router.get('/auth/google', async (ctx, next) => {
     measureCtx.info('try auth via', { provider: 'google' })
     const host = getHost(ctx.request.headers)
-    const branding = host !== undefined ? brandings[host]?.key ?? '' : ''
+    const branding = host !== undefined ? brandings[host]?.key ?? undefined : undefined
     const state = encodeURIComponent(
       JSON.stringify({
         inviteId: ctx.query?.inviteId,
@@ -53,14 +53,19 @@ export function registerGoogle (
     redirectURL,
     async (ctx, next) => {
       const state = safeParseAuthState(ctx.query?.state)
+      measureCtx.info('Auth state', { state })
       const branding = getBranding(brandings, state?.branding)
+      measureCtx.info('With branding', { branding })
+      const failureRedirect = concatLink(branding?.front ?? frontUrl, '/login')
+      measureCtx.info('With failure redirect', { failureRedirect })
 
       passport.authenticate('google', {
-        failureRedirect: concatLink(branding?.front ?? frontUrl, '/login'),
+        failureRedirect,
         session: true
       })(ctx, next)
     },
     async (ctx, next) => {
+      measureCtx.info('Provider auth success', { type: 'google', user: ctx.state?.user })
       const email = ctx.state.user.emails?.[0]?.value
       const first = ctx.state.user.name.givenName
       const last = ctx.state.user.name.familyName