[Linux][A11y] use ATK_ROLE_PASSWORD_TEXT for obscured text (flutter#3…

…3179)
naudzghebre · May 12, 2022 · 12b4baf · 12b4baf
1 parent 14871f1
commit 12b4baf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/shell/platform/linux/fl_accessible_node.cc b/shell/platform/linux/fl_accessible_node.cc
@@ -208,6 +208,10 @@ static AtkRole fl_accessible_node_get_role(AtkObject* accessible) {
   if ((self->flags & kFlutterSemanticsFlagIsSlider) != 0) {
     return ATK_ROLE_SLIDER;
   }
+  if ((self->flags & kFlutterSemanticsFlagIsTextField) != 0 &&
+      (self->flags & kFlutterSemanticsFlagIsObscured) != 0) {
+    return ATK_ROLE_PASSWORD_TEXT;
+  }
   if ((self->flags & kFlutterSemanticsFlagIsTextField) != 0) {
     return ATK_ROLE_TEXT;
   }

diff --git a/shell/platform/linux/fl_accessible_node_test.cc b/shell/platform/linux/fl_accessible_node_test.cc
@@ -108,6 +108,14 @@ TEST(FlAccessibleNodeTest, GetRole) {
   fl_accessible_node_set_flags(node, static_cast<FlutterSemanticsFlag>(
                                          kFlutterSemanticsFlagHasToggledState));
   EXPECT_EQ(atk_object_get_role(ATK_OBJECT(node)), ATK_ROLE_TOGGLE_BUTTON);
+
+  fl_accessible_node_set_flags(node, kFlutterSemanticsFlagIsTextField);
+  EXPECT_EQ(atk_object_get_role(ATK_OBJECT(node)), ATK_ROLE_TEXT);
+
+  fl_accessible_node_set_flags(
+      node, static_cast<FlutterSemanticsFlag>(kFlutterSemanticsFlagIsTextField |
+                                              kFlutterSemanticsFlagIsObscured));
+  EXPECT_EQ(atk_object_get_role(ATK_OBJECT(node)), ATK_ROLE_PASSWORD_TEXT);
 }
 
 // Checks Flutter actions are mapped to the appropriate ATK actions.