WIP - Listening IPv6 sockets may be both IPv4 and IPv6 #17866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilyam8 I cannot run the tests. Please help verify this works. For local-listeners, the report will be |
|
It did not work. It seems like we cannot open a socket by opening the fd from /proc. However, it works via netlink. So, I enabled libmnl by default. It is slower, but now we can have latency information (round trip time) and also total number of retransmits on the sockets. Since this is now using netlink, I think we need to test it works properly for containers too. |
|
Do not merge! The multi-threaded fork() is a bad idea. malloc locks are forked locked and the forked processes end up in deadlock. We need a spawn server for this work correctly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listening ipv6 sockets may be both ipv4 and ipv6, depending on the IPV6_ONLY flag
Tests: