Fix response generation broken by themeable syntax highlighting #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting. Signed-off-by: Adam Treat <treat.adam@gmail.com>
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 8b1fbfb in 41 seconds
More details
- Looked at
31lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_X959FlqLYkSg5GgV
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
| @@ -966,7 +966,7 @@ Rectangle { | |||
| textProcessor.codeColors.headerColor = theme.codeHeaderColor | |||
| textProcessor.codeColors.backgroundColor = theme.codeBackgroundColor | |||
| textProcessor.textDocument = textDocument | |||
| myTextArea.text = value | |||
| chatModel.forceUpdate(index); // called to trigger a reprocessing of the text | |||
There was a problem hiding this comment.
Using forceUpdate to trigger a re-render of text when theme or font settings change might lead to unnecessary performance overhead. Consider updating only the visual properties directly affected by these changes instead of reprocessing the entire text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes response generation issue by adding
forceUpdatemethod inChatModeland invoking it inChatView.qmlto handle theme changes.Key points:
forceUpdatemethod ingpt4all-chat/chatmodel.hto triggerdataChangedsignal forValueRole.gpt4all-chat/qml/ChatView.qmlto callchatModel.forceUpdate(index)for reprocessing text when theme changes.Generated with ❤️ by ellipsis.dev