Fix the alignment of placement new buffer for GenericValue.

When using operator[] on a GenericValue type clang-tidy complains, appropriately, about the alignment of the buffer used for placement-new of the "dummy" GenericValue.
northerntechie · Feb 9, 2022 · 1dff2ab · 1dff2ab
1 parent fd3dc29
commit 1dff2ab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/include/rapidjson/document.h b/include/rapidjson/document.h
@@ -1235,8 +1235,8 @@ class GenericValue {
             // return NullValue;
 
             // Use static buffer and placement-new to prevent destruction
-            static char buffer[sizeof(GenericValue)];
-            return *new (buffer) GenericValue();
+            static GenericValue buffer;
+            return *new (reinterpret_cast<char *>(&buffer)) GenericValue();
         }
     }
     template <typename SourceAllocator>