Merge pull request Tencent#1988 from Tencent/revert-1987-fix-placemen…

…t-new-alignment Revert "Fix the alignment of placement new buffer for GenericValue."
northerntechie · Feb 9, 2022 · e4bde97 · e4bde97
2 parents bf8ca5d + 88bbd87
commit e4bde97
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/include/rapidjson/document.h b/include/rapidjson/document.h
@@ -1235,8 +1235,8 @@ class GenericValue {
             // return NullValue;
 
             // Use static buffer and placement-new to prevent destruction
-            static GenericValid buffer;
-            return *new (reinterpret_cast<char *>(&buffer)) GenericValue();
+            static char buffer[sizeof(GenericValue)];
+            return *new (buffer) GenericValue();
         }
     }
     template <typename SourceAllocator>