[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard vnc auth broken #542

Closed
ganeshv opened this issue Oct 16, 2015 · 0 comments
Closed

Standard vnc auth broken #542

ganeshv opened this issue Oct 16, 2015 · 0 comments

Comments

@ganeshv
Copy link
Contributor
ganeshv commented Oct 16, 2015

Standard VNC auth with a password is broken, because a missing return in_negotiate_std_vnc_auth makes it proceed with a blank password instead of waiting for the password dialog. The following 1-liner fixes it:

--- a/include/rfb.js
+++ b/include/rfb.js
@@ -739,6 +739,7 @@ var RFB;
                 // an RFB state change and a UI interface issue
                 this._updateState('password', "Password Required");
                 this._onPasswordRequired(this);
+                return false;
             }

             if (this._sock.rQwait("auth challenge", 16)) { return false; }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ganeshv