[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for StoreWordLeft #2318

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Unit test for StoreWordLeft #2318

wants to merge 5 commits into from

Conversation

querolita
Copy link
Member

Fixes the interpreter to behave like Cannon.

Base automatically changed from zkvm/mips/fixme-register-access-underflow to master June 13, 2024 14:27
@dannywillems
Copy link
Member

If the instruction wasn't implemented incorrectly, it means we never had it in the past. I'm running the o1VM on the real infra to check this assumption.

@dannywillems
Copy link
Member

Without checking your changes, I think the previous implementation is correct. Running on your branch gives me this exit code:

Exited with code 2 at step 298805823
Halted at step=15726623 instruction=RType(SyscallExitGroup)
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ConstraintNotSatisfied("Unsatisfied expression: ((((Curr(x[16]) - 0x0100000000000000000000000000000000000000000000000000000000000000) * Curr(x[25])) + Curr(x[24])) - 0x0100000000000000000000000000000000000000000000000000000000000000)")', o1vm/src/main.rs:235:46

@dannywillems
Copy link
Member

On input

export L1_HEAD=0x05331e9873c201c108c1321d2488b298e8c1debe0429a054f7b0227e57821701
export L2_HEAD=0x81a28a79d8d687b048962799e98f2c5bc907b8bcd54c2ad948be9ca3fc4328f3
export L2_BLOCK_NUMBER=11729810
export STARTING_OUTPUT_ROOT=0x6487e31240348b7e3b7ea873e7acedfd406fd0538039cd9c75e3c2a5f42d49d1
export L2_CLAIM=0x358f7d8ace011fb2d773f2e85a55fffd4c37a55e733475990f1c896fbe7c93c7

dannywillems
dannywillems requested changes Jun 13, 2024
View reviewed changes
Copy link
Member
@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the failing e2e test

@querolita
Copy link
Member Author

@dannywillems

thread 'main' panicked at 'called Result::unwrap() on an Err value: ConstraintNotSatisfied("Unsatisfied expression: ((((Curr(x[16]) - 0x0100000000000000000000000000000000000000000000000000000000000000) * Curr(x[25])) + Curr(x[24])) - 0x0100000000000000000000000000000000000000000000000000000000000000)")', o1vm/src/main.rs:235:46

This used to fail before as well, as tracked here -> #2075

@querolita querolita mentioned this pull request Jun 13, 2024
Open
@querolita querolita marked this pull request as draft June 13, 2024 18:13
@querolita
Copy link
Member Author

Demo halts, making the PR a draft until solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannywillems dannywillems dannywillems requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@querolita @dannywillems