[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The schema of the run.language and toolComponent.language properties is incorrect. #488

Closed
aetos382 opened this issue Mar 12, 2021 · 3 comments
Closed

The schema of the run.language and toolComponent.language properties is incorrect. #488

aetos382 opened this issue Mar 12, 2021 · 3 comments
Labels
2.1.0-erratum design-approved The TC approved the design and I can write the change draft ready

Comments

@aetos382
Copy link
aetos382 commented Mar 12, 2021 •
edited
Loading

The pattern of the schema for the runs.tools.driver.language property is ^[a-zA-Z]{2}|^[a-zA-Z]{2}-[a-zA-Z]{2}]?$, but this will not entirely match language tags such as en-US.

sarif-spec/Schemata/sarif-schema-2.1.0.json

Line 2357 in a22c039

"pattern": "^[a-zA-Z]{2}|^[a-zA-Z]{2}-[a-zA-Z]{2}]?$"

@aetos382 aetos382 mentioned this issue Mar 12, 2021
Open
aeisenberg added a commit to aeisenberg/sarif-spec that referenced this issue Apr 9, 2021
@aeisenberg
Fix regex in language and locale recognition
f1f6ae7 
This was first mentioned in github/codeql-action#418
Also, raised in oasis-tcs#488.

cc: @lcartey
@aeisenberg aeisenberg mentioned this issue Apr 9, 2021
Closed
@michaelcfanning michaelcfanning added the design-approved The TC approved the design and I can write the change draft label Aug 12, 2021
@michaelcfanning
Copy link
Contributor

Approved during TC session 42.

@michaelcfanning
Copy link
Contributor
michaelcfanning commented Sep 14, 2021 •
edited
Loading

Bug exists in two locations, run.language and toolcomponent.language. Schema pattern updated to:

^(?i)[a-zA]{2}(-[a-z]{2})?$

@michaelcfanning michaelcfanning changed the title The schema of the language property is incorrect. The schema of the run.language and toolComponent.language properties is incorrect. Sep 14, 2021
@dmk42 dmk42 mentioned this issue Apr 21, 2022
Closed
5 tasks
@sthagen sthagen mentioned this issue May 20, 2023
Open
@dmk42
Copy link
Contributor
dmk42 commented Dec 19, 2023

Now that the Errata document has been published, this has been fixed in the official version of the standard.

@dmk42 dmk42 closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-erratum design-approved The TC approved the design and I can write the change draft ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aetos382 @michaelcfanning @dmk42