[go: nahoru, domu]

Skip to content

Commit

Permalink
Address deprecations and warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
oblakr24 committed Mar 17, 2024
1 parent f495217 commit 0ddccf4
Show file tree
Hide file tree
Showing 11 changed files with 42 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.Send
import androidx.compose.material.icons.filled.Send
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
Expand All @@ -30,8 +31,6 @@ import androidx.compose.ui.unit.dp
import com.rokoblak.chatbackup.ui.theme.AppThemePreviews
import com.rokoblak.chatbackup.ui.theme.ChatBackupTheme


@OptIn(ExperimentalComposeUiApi::class, ExperimentalMaterial3Api::class)
@Composable
fun InputBar(
input: String,
Expand Down Expand Up @@ -60,8 +59,9 @@ fun InputBar(
value = input,
onValueChange = onChange,
maxLines = 1,
colors = TextFieldDefaults.textFieldColors(
containerColor = bgColor,
colors = TextFieldDefaults.colors(
focusedContainerColor = bgColor,
unfocusedContainerColor = bgColor,
focusedIndicatorColor = Color.Transparent,
unfocusedIndicatorColor = Color.Transparent,
disabledIndicatorColor = Color.Transparent
Expand All @@ -86,7 +86,7 @@ fun InputBar(
}
) {
Icon(
imageVector = Icons.Filled.Send,
imageVector = Icons.AutoMirrored.Filled.Send,
tint = MaterialTheme.colorScheme.onPrimaryContainer,
contentDescription = "Clear input"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ package com.rokoblak.chatbackup.createchat

import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.*
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.material3.Divider
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
Expand Down Expand Up @@ -43,7 +42,7 @@ fun ContactsListing(data: ContactsListingData, onItemClicked: (cId: String, numb
data = item,
)
if (idx < data.items.lastIndex) {
Divider(color = MaterialTheme.colorScheme.primary, thickness = 1.dp)
HorizontalDivider(color = MaterialTheme.colorScheme.primary, thickness = 1.dp)
}
}
)
Expand Down
7 changes: 4 additions & 3 deletions app/src/main/java/com/rokoblak/chatbackup/home/HomeContent.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import androidx.activity.compose.rememberLauncherForActivityResult
import androidx.activity.result.contract.ActivityResultContracts
import androidx.compose.foundation.layout.*
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.Message
import androidx.compose.material.icons.filled.Message
import androidx.compose.material.icons.filled.Settings
import androidx.compose.material3.Text
Expand Down Expand Up @@ -62,7 +63,7 @@ fun HomeContent(
// then gently explain why the app requires this permission
Text("The app needs to read messages and contacts in order to list and export the data. Please grant the necessary permissions.")

ButtonWithIcon("Grant permissions", icon = Icons.Filled.Message) {
ButtonWithIcon("Grant permissions", icon = Icons.AutoMirrored.Filled.Message) {
onLaunchPermissions()
}
} else {
Expand All @@ -85,7 +86,7 @@ fun HomeContent(
)
}
} else {
ButtonWithIcon("Grant permissions", icon = Icons.Filled.Message) {
ButtonWithIcon("Grant permissions", icon = Icons.AutoMirrored.Filled.Message) {
onLaunchPermissions()
}
}
Expand All @@ -102,7 +103,7 @@ fun HomeContent(

Spacer(modifier = Modifier.height(24.dp))

ButtonWithIcon("Set as default", icon = Icons.Filled.Message) {
ButtonWithIcon("Set as default", icon = Icons.AutoMirrored.Filled.Message) {
onAction(HomeAction.OpenSetAsDefaultClicked)
}
}
Expand Down
8 changes: 5 additions & 3 deletions app/src/main/java/com/rokoblak/chatbackup/home/HomeDrawer.kt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.wrapContentWidth
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.Message
import androidx.compose.material.icons.automirrored.filled.OpenInNew
import androidx.compose.material.icons.filled.Code
import androidx.compose.material.icons.filled.Message
import androidx.compose.material.icons.filled.OpenInNew
Expand Down Expand Up @@ -49,12 +51,12 @@ fun HomeDrawer(
if (state.showComposeAndImport) {
ButtonWithIcon(modifier = Modifier.padding(horizontal = 16.dp),
text = "Compose",
icon = Icons.Filled.Message,
icon = Icons.AutoMirrored.Filled.Message,
onClick = { onAction(HomeAction.ComposeClicked) })
Spacer(modifier = Modifier.height(8.dp))
ButtonWithIcon(modifier = Modifier.padding(horizontal = 16.dp),
text = "Import",
icon = Icons.Filled.OpenInNew,
icon = Icons.AutoMirrored.Filled.OpenInNew,
onClick = { onAction(HomeAction.ImportClicked) })
Spacer(modifier = Modifier.height(8.dp))
}
Expand Down Expand Up @@ -117,7 +119,7 @@ fun HomeDrawer(
) {
Text("This is not the default SMS app.\nChange to enable additional functionalities such as restoring imported messages and deleting.")
Spacer(modifier = Modifier.height(12.dp))
ButtonWithIcon("Make default", Icons.Filled.Message) {
ButtonWithIcon("Make default", Icons.AutoMirrored.Filled.Message) {
onAction(HomeAction.OpenSetAsDefaultClicked)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.rokoblak.chatbackup.home

import androidx.compose.foundation.layout.padding
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.Message
import androidx.compose.material.icons.filled.Message
import androidx.compose.material3.DrawerState
import androidx.compose.material3.DrawerValue
Expand Down Expand Up @@ -81,7 +82,7 @@ private fun HomeScaffoldContent(
if (state.contentPermissions is HomeContentUIPermissionsState.PermissionsGiven) {
ButtonWithIcon(modifier = Modifier,
text = "Compose",
icon = Icons.Filled.Message,
icon = Icons.AutoMirrored.Filled.Message,
onClick = { onAction(HomeAction.ComposeClicked) })
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ fun HomeTopAppBar(
onNavIconClick: () -> Unit
) {
TopAppBar(
colors = TopAppBarDefaults.smallTopAppBarColors(
colors = TopAppBarDefaults.topAppBarColors(
containerColor = MaterialTheme.colorScheme.primaryContainer,
titleContentColor = MaterialTheme.colorScheme.onPrimaryContainer
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import androidx.compose.foundation.background
import androidx.compose.foundation.layout.*
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.Message
import androidx.compose.material.icons.automirrored.filled.OpenInNew
import androidx.compose.material.icons.filled.*
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
Expand Down Expand Up @@ -42,7 +44,7 @@ fun ImportTopToolbar(
onAction: (ImportAction) -> Unit,
) {
TopAppBar(
colors = TopAppBarDefaults.smallTopAppBarColors(
colors = TopAppBarDefaults.topAppBarColors(
containerColor = MaterialTheme.colorScheme.primaryContainer,
titleContentColor = MaterialTheme.colorScheme.primaryContainer
),
Expand Down Expand Up @@ -84,7 +86,7 @@ fun ImportTopToolbar(
.widthIn(20.dp, 220.dp)
)
val owner = LocalContext.current
ButtonWithIcon("Set as default", Icons.Filled.Message) {
ButtonWithIcon("Set as default", Icons.AutoMirrored.Filled.Message) {
openSMSDefaultPrompt = false
onAction(ImportAction.OpenSetAsDefaultClicked(owner))
}
Expand Down Expand Up @@ -230,7 +232,7 @@ fun ImportTopToolbar(
}
) {
Icon(
imageVector = Icons.Filled.OpenInNew,
imageVector = Icons.AutoMirrored.Filled.OpenInNew,
contentDescription = "Show open file submenu"
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,18 @@ package com.rokoblak.chatbackup.ui.commonui
import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.*
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.ImportExport
import androidx.compose.material3.Divider
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
Expand Down Expand Up @@ -108,7 +114,7 @@ fun ConversationsListing(
})

if (idx < state.items.lastIndex) {
Divider(color = MaterialTheme.colorScheme.primary, thickness = 1.dp)
HorizontalDivider(color = MaterialTheme.colorScheme.primary, thickness = 1.dp)
}
}
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.wrapContentHeight
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.ArrowBack
import androidx.compose.material.icons.filled.Add
import androidx.compose.material.icons.filled.ArrowBack
import androidx.compose.material3.MaterialTheme
Expand Down Expand Up @@ -64,7 +65,7 @@ fun DetailsHeader(
contentAlignment = Alignment.CenterStart
) {
Image(
imageVector = Icons.Filled.ArrowBack,
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
contentDescription = null,
modifier = Modifier
.fillMaxHeight()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ fun SearchBar(
modifier = modifier
.padding(horizontal = 16.dp, vertical = 4.dp)
.fillMaxWidth()
.height(50.dp).clip(RoundedCornerShape(25.dp)),
.height(50.dp)
.clip(RoundedCornerShape(25.dp)),
shadowElevation = 4.dp,
border = BorderStroke(1.dp, MaterialTheme.colorScheme.onPrimary.alpha(0.5f)),
shape = RoundedCornerShape(25.dp),
Expand All @@ -66,7 +67,10 @@ fun SearchBar(
value = text,
onValueChange = onChange,
maxLines = 1,
colors = TextFieldDefaults.textFieldColors(containerColor = MaterialTheme.colorScheme.background),
colors = TextFieldDefaults.colors(
focusedContainerColor = MaterialTheme.colorScheme.background,
unfocusedContainerColor = MaterialTheme.colorScheme.background
),
placeholder = {
Text(
text = placeholder,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fun ChatBackupTheme(
overrideDarkMode: Boolean? = null,
darkTheme: Boolean = overrideDarkMode ?: isSystemInDarkTheme(),
// Dynamic color is available on Android 12+
dynamicColor: Boolean = true,
// dynamicColor: Boolean = true,
content: @Composable () -> Unit
) {
val colorScheme = when {
Expand Down

0 comments on commit 0ddccf4

Please sign in to comment.