[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: less warnings is more (fixes #3699) #3703

Merged
merged 15 commits into from
Jul 3, 2024
Merged

actions: less warnings is more (fixes #3699) #3703

merged 15 commits into from
Jul 3, 2024

Conversation

rlam20
Copy link
Contributor
@rlam20 rlam20 commented Jun 26, 2024

fixes #3699

@rlam20 rlam20 linked an issue Jun 26, 2024 that may be closed by this pull request
warnings in MyTeamsDetailFragment #3699
Closed
@rlam20 rlam20 marked this pull request as ready for review June 26, 2024 20:07
@rlam20 rlam20 requested a review from Okuro3499 June 28, 2024 18:45
@dogi dogi requested a review from ewhang5 July 1, 2024 17:36
ewhang5
ewhang5 requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor
@ewhang5 ewhang5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @Okuro3499. The first comment would simply require an else branch that satisfies that same functionality as "createNews(map, mRealm, user, imageList)"

@rlam20 rlam20 requested review from Okuro3499 and ewhang5 July 1, 2024 20:06
ewhang5
ewhang5 requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor
@ewhang5 ewhang5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the really small issues, I think the rest of this pr looks good!

ewhang5
ewhang5 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor
@ewhang5 ewhang5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I would solve the conflicts that are shown below to make the merge easier, and those should be very minor conflicts.

@rlam20 rlam20 requested a review from Okuro3499 July 2, 2024 18:38
@dogi dogi merged commit 47a67b7 into master Jul 3, 2024
0 of 2 checks passed
dogi added a commit that referenced this pull request Jul 3, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
e653551 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
dogi added a commit that referenced this pull request Jul 3, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
36f9a51 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
@Okuro3499 Okuro3499 deleted the 3699-warnings-in-myteamsdetailfragment branch July 9, 2024 09:43
Okuro3499 added a commit that referenced this pull request Jul 22, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
356b351 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
Okuro3499 added a commit that referenced this pull request Jul 24, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
068db5d 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
Okuro3499 added a commit that referenced this pull request Aug 7, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
f3ff1d2 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
Okuro3499 added a commit that referenced this pull request Aug 13, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
3925efb 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
Okuro3499 added a commit that referenced this pull request Aug 16, 2024
@rlam20 @Okuro3499 @dogi
actions: less warnings is more (fixes #3699) (#3703)
1d7ac5e 
Co-authored-by: Gideon Okuro <gideonollonde@gmail.com>
Co-authored-by: dogi <dogi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogi dogi dogi approved these changes

@ewhang5 ewhang5 ewhang5 approved these changes

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@strawberrybread strawberrybread strawberrybread approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warnings in MyTeamsDetailFragment
5 participants
@rlam20 @dogi @ewhang5 @Okuro3499 @strawberrybread