feat: add mongoose instrumentation #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habmic
approved these changes
Aug 29, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 96.07% 96.18% +0.11%
==========================================
Files 14 15 +1
Lines 892 944 +52
Branches 191 195 +4
==========================================
+ Hits 857 908 +51
- Misses 35 36 +1
|
vmarchaud
approved these changes
Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream mongoose MongoDB ORM from ext-js repo to contrib.
The mongoose package has 1.8M weekly downloads on npm. The instrumentation has 6.6K weekly downloads on npm and it has been running in production environments for about 2 years with no issues.
I took the opportunity of changing the instrumentation package name and applied a few breaking changes which are documented in the README.md file. I also added support for mongoose version 6, and added
test-all-versionsto verify the supported version range works.The code itself is ported AS IS and can be improved in future PRs.