[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: version 0.13.0 #316

Merged
merged 7 commits into from
Feb 1, 2021
Merged

chore: version 0.13.0 #316

merged 7 commits into from
Feb 1, 2021

Conversation

dyladan
Copy link
Member
@dyladan dyladan commented Jan 22, 2021 •
edited
Loading

@dyladan dyladan requested a review from a team as a code owner January 22, 2021 18:21
@codecov
Copy link
codecov bot commented Jan 22, 2021 •
edited
Loading

Codecov Report

Merging #316 (2e802a3) into main (eb7ebd1) will not change coverage.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         119      119           
  Lines        6273     6273           
  Branches      609      609           
=======================================
  Hits         5990     5990           
  Misses        283      283
Impacted Files Coverage Δ
...ntelemetry-resource-detector-github/src/version.ts 0.00% <0.00%> (ø)
...metry-propagator-grpc-census-binary/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <100.00%> (ø)
...entelemetry-instrumentation-graphql/src/version.ts 100.00% <100.00%> (ø)
...s/node/opentelemetry-plugin-pg-pool/src/version.ts 100.00% <100.00%> (ø)
...lugins/node/opentelemetry-plugin-pg/src/version.ts 100.00% <100.00%> (ø)
...web/opentelemetry-plugin-react-load/src/version.ts 100.00% <100.00%> (ø)

@dyladan dyladan mentioned this pull request Jan 22, 2021
Closed
@obecny
Copy link
Member
obecny commented Jan 22, 2021

I don't think we should release anything without updating the examples to be up to date. These are the first thing people are testing and it will break and confuse them immediately, not even mentioning that simply checking that it still works fine. We are asking for troubles :/

@dyladan
Copy link
Member Author
dyladan commented Jan 22, 2021

I'll update examples monday

@Flarna Flarna mentioned this pull request Jan 25, 2021
Closed
@obecny
Copy link
Member
obecny commented Jan 26, 2021

I'll update examples monday

@dyladan are you planning to add this yet in this PR or it will be separate PR ?

@dyladan
Copy link
Member Author
dyladan commented Jan 26, 2021

I'll update examples monday

@dyladan are you planning to add this yet in this PR or it will be separate PR ?

this PR. there are a lot of examples and it isn't highest priority. i'm still working on it.

@obecny
Copy link
Member
obecny commented Jan 26, 2021

I'll update examples monday

@dyladan are you planning to add this yet in this PR or it will be separate PR ?

this PR. there are a lot of examples and it isn't highest priority. i'm still working on it.

we can split work if you want, merge this PR, create a new with examples you already have can help with other examples then

@dyladan
Copy link
Member Author
dyladan commented Jan 26, 2021 •
edited
Loading

it's fine. the only time consuming part is that the examples reference unpublished versions of the plugins so i have to install them by filepath, verify they work, then switch it back. Most of the examples don't use API directly so they work just fine without modification.

@dyladan
Copy link
Member Author
dyladan commented Jan 27, 2021

Examples updated @obecny

Base automatically changed from master to main January 27, 2021 22:21
@mwear
Copy link
Member
mwear commented Jan 28, 2021

If it's not too late, and not too much to ask, could #318 go into this release?

@Flarna
Copy link
Member
Flarna commented Jan 30, 2021

I think this should wait for #329

@obecny
Copy link
Member
obecny commented Feb 1, 2021

I think this should wait for #329

this was merged, I don't want to yet publish the core 0.16 without releasing this one first. @dyladan do you think you can publish this one yet today ?

@dyladan
Copy link
Member Author
dyladan commented Feb 1, 2021

Sorry we had a new team member join today so my morning was full of meetings and such. I will release now

@dyladan dyladan merged commit 9d7446d into open-telemetry:main Feb 1, 2021
@dyladan dyladan deleted the 0.13.0-proposal branch February 1, 2021 18:50
@willarmiros willarmiros mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny approved these changes

@mwear mwear mwear approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

@naseemkullah naseemkullah naseemkullah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dyladan @obecny @mwear @Flarna @vmarchaud @naseemkullah