Fix proto 1.1.0 trace flags (#1216)

open-telemetry · Jan 17, 2024 · 1af8334 · 1af8334
1 parent 102f5dc
commit 1af8334
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Contrib/Otlp/SpanConverter.php b/src/Contrib/Otlp/SpanConverter.php
@@ -173,7 +173,7 @@ private function convertSpan(SpanDataInterface $span): Span
             $pSpan->getLinks()[] = $pLink = new Link();
             $pLink->setTraceId($this->serializer->serializeTraceId($link->getSpanContext()->getTraceIdBinary()));
             $pLink->setSpanId($this->serializer->serializeSpanId($link->getSpanContext()->getSpanIdBinary()));
-            $pLink->setFlags($span->getContext()->getTraceFlags());
+            $pLink->setFlags($link->getSpanContext()->getTraceFlags());
             $pLink->setTraceState((string) $link->getSpanContext()->getTraceState());
             $this->setAttributes($pLink, $link->getAttributes());
         }

diff --git a/src/Contrib/Otlp/composer.json b/src/Contrib/Otlp/composer.json
@@ -19,7 +19,7 @@
   "require": {
     "php": "^7.4 || ^8.0",
     "php-http/discovery": "^1.14",
-    "open-telemetry/gen-otlp-protobuf": "^1.0",
+    "open-telemetry/gen-otlp-protobuf": "^1.1",
     "open-telemetry/api": "^1.0",
     "open-telemetry/sdk": "^1.0"
   },

diff --git a/src/Contrib/composer.json b/src/Contrib/composer.json
@@ -15,7 +15,7 @@
         "ext-json": "*",
         "open-telemetry/api": "^1.0",
         "open-telemetry/context": "^1.0",
-        "open-telemetry/gen-otlp-protobuf": "^1.0",
+        "open-telemetry/gen-otlp-protobuf": "^1.1",
         "open-telemetry/sdk": "^1.0",
         "open-telemetry/sem-conv": "^1.0",
         "php-http/async-client-implementation": "^1.0",