[dataset-manager] apply partial dataset config on channel set failure #10490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report of OpenThread
|
EskoDijk
reviewed
Jul 9, 2024
src/core/meshcop/dataset_manager.cpp
Outdated
| @@ -199,8 +199,7 @@ Error DatasetManager::ApplyConfiguration(const Dataset &aDataset) const | |||
|
|
|||
| if (error != kErrorNone) | |||
| { | |||
| LogWarn("ApplyConfiguration() Failed to set channel to %d (%s)", channel, ErrorToString(error)); | |||
| ExitNow(); | |||
| LogWarn("Failed to set channel to %u when applying dataset: %s", channel, ErrorToString(error)); | |||
There was a problem hiding this comment.
What about LogCrit() here? LogWarn is normally pretty mild like e.g. failing to send a particular message (which can be easily retried) or not able to store some extra items. While this error is critical: the dataset defines a channel that the device can't support, and that's pretty final. (Typically hardcoded in the platform in the supported-channels mask.) So the entire Thread device can't operate anymore as part of the network, on the intended channel.
There was a problem hiding this comment.
Thanks @EskoDijk . I think using LogCrit() can be useful. Updated in new push.
This commit updates `DatasetManager::ApplyConfiguration()` to apply the rest of the parameters in the Dataset even if setting the channel fails. The channel error is now logged as `LogCrit()`.
295c9d0
to
a2f70e5
Compare
jwhui
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
DatasetManager::ApplyConfiguration()to apply the rest of the parameters in the Dataset even if setting the channel fails.