Fix gemm_fusion_autotuner_test on Hopper #14796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuegel
approved these changes
Jul 11, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
Imported from GitHub PR openxla/xla#14796 Updated result type and error thresholds for the SelectsSplitK test. Previously this failed on Hopper. Copybara import of the project: -- 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 by Sergey Kozub <skozub@nvidia.com>: Fix gemm_fusion_autotuner_test on Hopper Merging this change closes #14796 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 651348522
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
Imported from GitHub PR openxla/xla#14796 Updated result type and error thresholds for the SelectsSplitK test. Previously this failed on Hopper. Copybara import of the project: -- 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 by Sergey Kozub <skozub@nvidia.com>: Fix gemm_fusion_autotuner_test on Hopper Merging this change closes #14796 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 651348522
Merged
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650317473
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
Imported from GitHub PR openxla/xla#14796 Updated result type and error thresholds for the SelectsSplitK test. Previously this failed on Hopper. Copybara import of the project: -- 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 by Sergey Kozub <skozub@nvidia.com>: Fix gemm_fusion_autotuner_test on Hopper Merging this change closes #14796 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650257579
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650298390
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650827514
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
We already converted triton gpu dialect to nvvm in TritonGPUTOLLVMPass but since we need to lower SparseDot afterwards and we generate a gpu.thread_id in the lowering, add a pattern to also convert that to nvvm. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650924687
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650567453
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650300991
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650827506
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650824283
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650990450
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 650075692
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 651370257
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
This is needed for M_LN2l Without the include the build is failing on MacOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 651373744
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
`DetectUnusedVariables` can be expensive, but often we don't have symbols in the indexing map at all, so there is nothing to remove. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 651370098
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
- Inline Clear and Consume into Start and Stop. - Replace internal::g_trace_level with a private class, TraceLevel. - Rename SplitEventTracker to IncompleteEventTracker. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 645012398
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
- Inline Clear and Consume into Start and Stop. - Replace internal::g_trace_level with a private class, TraceLevel. - Rename SplitEventTracker to IncompleteEventTracker. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 PiperOrigin-RevId: 645012398
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jul 11, 2024
Imported from GitHub PR openxla/xla#14796 Updated result type and error thresholds for the SelectsSplitK test. Previously this failed on Hopper. Copybara import of the project: -- 5005f288b67a2a34ec643cfcc3fbae815b5f0ef6 by Sergey Kozub <skozub@nvidia.com>: Fix gemm_fusion_autotuner_test on Hopper Merging this change closes #14796 PiperOrigin-RevId: 651359673
i-chaochen
pushed a commit
to ROCm/xla
that referenced
this pull request
Jul 15, 2024
Imported from GitHub PR openxla#14796 Updated result type and error thresholds for the SelectsSplitK test. Previously this failed on Hopper. Copybara import of the project: -- 5005f28 by Sergey Kozub <skozub@nvidia.com>: Fix gemm_fusion_autotuner_test on Hopper Merging this change closes openxla#14796 COPYBARA_INTEGRATE_REVIEW=openxla#14796 from openxla:skozub/gemm_fusion_autotuner_test 5005f28 PiperOrigin-RevId: 651359673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated result type and error thresholds for the SelectsSplitK test.
Previously this failed on Hopper.