[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTorch version in install_nvidia.sh #439

Closed
wants to merge 7 commits into from

Conversation

stefaniapedrazzi
Copy link
Collaborator
@stefaniapedrazzi stefaniapedrazzi commented Jun 5, 2023

In #431 we updated the module versions but this script was not updated:

  • PyTorch from 1.9.0 to 1.13.1
  • Torchvision from 0.10.0 to 0.14.1

In this PR, I propose some changes to update the Python modules version but I'm not sure if they will work on the NVIDIA TX2/AGX/NX .

@stefaniapedrazzi stefaniapedrazzi added the test release Tests if a wheel created from a branch runs correctly label Jun 5, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jun 5, 2023
@stefaniapedrazzi stefaniapedrazzi added test release Tests if a wheel created from a branch runs correctly test tools Test the toolkit methods test packages Test pip wheel and docker image and removed test release Tests if a wheel created from a branch runs correctly labels Jun 5, 2023
@Pavlos-Tosidis
Copy link
Collaborator

Hello Stefania, I am gonna have a look into that and update to the closest version available soon

@omichel
Copy link
Collaborator
omichel commented Aug 28, 2023

Hi @Pavlos-Tosidis, did you have a chance to look into this?

@Pavlos-Tosidis
Copy link
Collaborator

Yeah, meant to comment on it on todays TMT meeting.
So, 1.9 is the latest version supported by TX2.
Unfortunately, even Nvidia stopped maintaining the JetPack for TX2 so we have to keep the current one (Ubuntu 18.04, with everything that this implies, e.g. python3.6.9). But since the installation on the embedded devices is not the same as the toolkit for Desktop, updating the repo on the docker images to pull the changes made to the master branch and adding a couple of new dependencies worked fine. (At least all scripts under /projects/python).
The question now is if we want to keep supporting TX2 and keep the current images and just update the repo used whenever we add/update something, or ditch TX2 or make a new image for NX devices, which support newer JetPack versions and update all dependencies to be the same, if applicable, with the Desktop version.

@omichel
Copy link
Collaborator
omichel commented Aug 29, 2023

In that case, I believe we should drop support for TX2 in the main branch of this repository otherwise we will be blocked with updating PyTorch. Using willing to use the unsupported TX2 may still revert to an older commit on this repo or older images (which we should document).

@passalis
Copy link
Collaborator

One other possibility would be to keep the installation for tx-2 only for the tools not failing, i.e., keep the script as it is and add a notice with a list of tools that do not work in this platform (unless nothing works in the updated version, so this should be indeed tackled in a different manner).

@passalis
Copy link
Collaborator
passalis commented Sep 4, 2023

We can keep the current version on TX-2 image, so we can close this for now.

@passalis passalis closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test packages Test pip wheel and docker image test tools Test the toolkit methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants